From cbebac3254faea2295e330b796517985cdcf9d1d Mon Sep 17 00:00:00 2001 From: Incido Developer Date: Thu, 17 Sep 2026 18:24:12 +1200 Subject: [PATCH] fix(release): stop copying the notes file onto itself before upload NOTES_FILE is already /tmp/Incido--changes.md, so 'cp $NOTES_FILE /tmp/$NOTES_ASSET' was a self-copy: cp exits 1 and set -e aborted the step AFTER both APKs had uploaded. That is what turned run 78 (tag v0.3.8.1) red - the LAN API change itself worked, the release and both APK assets landed first. Upload $NOTES_FILE directly instead. --- .gitea/workflows/release.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitea/workflows/release.yml b/.gitea/workflows/release.yml index a8fd1a4..9e210ed 100644 --- a/.gitea/workflows/release.yml +++ b/.gitea/workflows/release.yml @@ -212,8 +212,10 @@ jobs: NOTES_ASSET="Incido-$VERSION-changes.md" echo "--- Deleting stale asset for $NOTES_ASSET ---" python3 /tmp/delete_asset.py "$API" "$RELEASE_ID" "$NOTES_ASSET" "$GH_TOKEN" - cp "$NOTES_FILE" "/tmp/$NOTES_ASSET" - upload_asset "$NOTES_ASSET" "/tmp/$NOTES_ASSET" || exit 1 + # Upload $NOTES_FILE directly: it already IS /tmp/, so + # copying it onto itself made cp fail with exit 1 and killed the + # whole step (set -e) after the APKs had uploaded fine. + upload_asset "$NOTES_ASSET" "$NOTES_FILE" || exit 1 fi echo "--- Final release state ---"