fix(release): stop copying the notes file onto itself before upload
NOTES_FILE is already /tmp/Incido-<version>-changes.md, so 'cp $NOTES_FILE /tmp/$NOTES_ASSET' was a self-copy: cp exits 1 and set -e aborted the step AFTER both APKs had uploaded. That is what turned run 78 (tag v0.3.8.1) red - the LAN API change itself worked, the release and both APK assets landed first. Upload $NOTES_FILE directly instead.
This commit is contained in:
1 parent
ab26fe5f98
commit
18a1478962
1 file changed
+4
-2
@@ -212,8 +212,10 @@ jobs:
|
||||
NOTES_ASSET="Incido-$VERSION-changes.md"
|
||||
echo "--- Deleting stale asset for $NOTES_ASSET ---"
|
||||
python3 /tmp/delete_asset.py "$API" "$RELEASE_ID" "$NOTES_ASSET" "$GH_TOKEN"
|
||||
cp "$NOTES_FILE" "/tmp/$NOTES_ASSET"
|
||||
upload_asset "$NOTES_ASSET" "/tmp/$NOTES_ASSET" || exit 1
|
||||
# Upload $NOTES_FILE directly: it already IS /tmp/<asset name>, so
|
||||
# copying it onto itself made cp fail with exit 1 and killed the
|
||||
# whole step (set -e) after the APKs had uploaded fine.
|
||||
upload_asset "$NOTES_ASSET" "$NOTES_FILE" || exit 1
|
||||
fi
|
||||
|
||||
echo "--- Final release state ---"
|
||||
|
||||
Reference in new issue
Block a user